Remove blocked feature of extra menus for project items' parent folders
ClosedPublic
Actions

Authored by kossebau on Jun 15 2017, 3:30 PM.

Details

Reviewers

Group Reviewers

Commits

R32:f008a6cdfb06: Remove blocked feature of extra menus for project items' parent folders
R33:f008a6cdfb06: Remove blocked feature of extra menus for project items' parent folders

Summary

Feature has been accidentally disabled in 2013 due to porting mistake
with inverted logic in commit 0e00aa2a85254e90ec945c8c35b6aed3389edab8:
"!parent->url().isEmpty()" became wrongly "!parent->path().isValid()"

Seems no-one missed the featzure since. Besides, the UX is questionable
custom with the separate new menus popping up instead of being in submenus.

So removing as dead code for now.

Diff Detail

Repository

R33 KDevPlatform

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.Jun 15 2017, 3:30 PM

Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptJun 15 2017, 3:30 PM

The feature added entries like this:

Selecting an entry would then pop-up an new menu, like this:

+1. I don't think it is missed.

This revision is now accepted and ready to land.Jun 16 2017, 7:27 AM

Closed by commit R33:f008a6cdfb06: Remove blocked feature of extra menus for project items' parent folders (authored by kossebau). · Explain WhyJun 18 2017, 11:35 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/projectmanagerview/projecttreeview.cpp (3 lines)
M			project/projectutils.h (6 lines)
M			project/projectutils.cpp (77 lines)
M			shell/textdocument.cpp (11 lines)