Details
- Reviewers
nienhueser rahn - Commits
- R34:e30a44afb879: Introduce the GeoDataBuilding class
Diff Detail
- Repository
- R34 Marble
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/lib/marble/geodata/data/GeoDataBuilding.cpp | ||
---|---|---|
18 ↗ | (On Diff #15448) | guess you want to create a new GeoDataBuildingPrivate here |
23 ↗ | (On Diff #15448) | must delete d here. Also a copy ctor and assigment operator are needed to deal with the pointer member correctly. |
src/lib/marble/geodata/data/GeoDataBuilding.h | ||
83 ↗ | (On Diff #15448) | Let's use QVector<int> instead of a pointer to int, the latter is c-ish and error-prone. |
103 ↗ | (On Diff #15448) | Do we need a setter? If not (and GeoDataBuilding takes care of creating the instance it returns) then ownership is clear. |
src/lib/marble/geodata/data/GeoDataBuilding_p.h | ||
---|---|---|
33 | The pointer member here is still not handled correctly. E.g. when copying a GeoDataBuilding instance, the code currently would result in a double delete when both go out of scope. The easiest way around it would be to change it to |
src/lib/marble/geodata/data/GeoDataBuilding_p.h | ||
---|---|---|
29 ↗ | (On Diff #15448) | Should be of double type. |
I miss a "sane" constructor. What about introducing a unit test so the class is used in one place at least for a basic sanity check?