Introduce the password provider class
ClosedPublic
Actions

Authored by aacid on Jun 12 2017, 11:24 PM.

Details

Reviewers

dvratil
mlaurent

Commits

R91:8f9f19a88f9e: Introduce the password provider class

Summary

Instead of using the dbus interface of resources to get the passwords

Repository

R91 PIM: Sieve Handling Library

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Restricted Application added a subscriber: KDE PIM. · View Herald Transcript

You missed to increase libksieve version.

src/ksieveui/util/autotests/utilmethodtest.cpp
37	it's in still in 17.04 it's Q_DECL_OVERRIDE if you put in master it's override.
src/ksieveui/vacation/vacation.h
62	mPasswordProvider.
src/ksieveui/widgets/custommanagesievewidget.h
36	mPasswordProvider

This revision now requires changes to proceed.Jun 13 2017, 4:42 AM

src/ksieveui/debug/sievedebugdialog.h
64	mPasswordProvider

Improvements suggested by Laurent

there is a lot of unrelated changes but ok ship it

This revision is now accepted and ready to land.Jun 14 2017, 4:53 AM

This revision was automatically updated to reflect the committed changes.

		Path
M		src/ksieveui/CMakeLists.txt (1 line)
M		src/ksieveui/debug/sievedebugdialog.h (6 lines)
M		src/ksieveui/debug/sievedebugdialog.cpp (7 lines)
M		src/ksieveui/managesievescriptsdialog.h (3 lines)
M		src/ksieveui/managesievescriptsdialog.cpp (4 lines)
M		src/ksieveui/util/abstractakonadiimapsettinginterface.h (2 lines)
M		src/ksieveui/util/abstractakonadiimapsettinginterface.cpp (12 lines)
M		src/ksieveui/util/akonadiimapsettinginterface.h (2 lines)
M		src/ksieveui/util/akonadiimapsettinginterface.cpp (23 lines)
M		src/ksieveui/util/autotests/akonadiimapsettinginterfacetest.h (2 lines)
M		src/ksieveui/util/autotests/akonadiimapsettinginterfacetest.cpp (12 lines)
M		src/ksieveui/util/autotests/utilmethodtest.cpp (27 lines)
A	M	src/ksieveui/util/sieveimappasswordprovider.h (39 lines)
M		src/ksieveui/util/util.cpp (15 lines)
M		src/ksieveui/util/util_p.h (5 lines)
M		src/ksieveui/vacation/multiimapvacationmanager.h (4 lines)
M		src/ksieveui/vacation/multiimapvacationmanager.cpp (5 lines)
M		src/ksieveui/vacation/vacation.h (4 lines)
M		src/ksieveui/vacation/vacation.cpp (5 lines)
M		src/ksieveui/vacation/vacationmanager.h (3 lines)
M		src/ksieveui/vacation/vacationmanager.cpp (4 lines)
M		src/ksieveui/widgets/custommanagesievewidget.h (6 lines)
M		src/ksieveui/widgets/custommanagesievewidget.cpp (5 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15409	4f15cd0		Jun 12 2017, 11:24 PM	★	★
Diff 2	15440	57bce87	Improvements suggested by Laurent	Jun 13 2017, 10:44 PM	★	★
Diff 3	15476	8e8d431	R91:8f9f19a88f9e90a9786f05f458af980b84d69625	Jun 15 2017, 8:11 PM	★	★