Differential D6169

Make the sidebar actions look selected when corresponding view is loaded
ClosedPublic
Actions

Authored by atulsharma on Jun 10 2017, 12:26 PM.

Details

Reviewers
mart
Group Reviewers
Koko
Maniphest Tasks
T6304: make sidebar actions look selected when the corresponding view is loaded

Diff Detail

Repository
R659 Koko Image Gallery
Lint
Lint Skipped
Unit
Unit Tests Skipped
mart added a subscriber: mart.Jun 10 2017, 5:27 PM
mart added inline comments.
qmlUiKirigami/Sidebar.qml
30

this property can be an Action so you don't have to use findAction

qmlUiKirigami/main.qml
44

no need of findAction, you can do previouslySelectedAction.checked = false

atulsharma updated this revision to Diff 15343.Jun 11 2017, 5:25 AM
atulsharma marked 2 inline comments as done.
mart accepted this revision.Jun 11 2017, 6:29 PM
This revision is now accepted and ready to land.Jun 11 2017, 6:29 PM
atulsharma closed this revision.Jun 20 2017, 10:47 AM

Revision Contents
Changeset List

PathPackages
MqmlUiKirigami/Sidebar.qml (32 lines)
MqmlUiKirigami/main.qml (7 lines)

Diff 15343

View Options

qmlUiKirigami/Sidebar.qml

Loading...
View Options

qmlUiKirigami/main.qml

Loading...