Differential D614

Fix opening of archives whose mimetype cannot be detected-by-content
ClosedPublic
Actions

Authored by elvisangelaccio on Nov 28 2015, 5:14 PM.

Details

Reviewers
rthomsen
Summary

It looks like shared-mime-info, and thus QMimeDatabase, cannot detect-by-content tar archives created with the --format=v7 flag.
Instead of adding another exception (like we did for ISO files), let's just use the mime detected from the extension if the one from content could not be determined.

BUG: 355955
FIXED-IN: 15.12.0

Test Plan

Opening uncompressed tar v7 archives now works. Opening ISO files still works.

Diff Detail

Repository
R36 Ark
Branch
bug/355955
Lint
No Linters Available
Unit
No Unit Test Coverage
elvisangelaccio updated this revision to Diff 1419.Nov 28 2015, 5:14 PM
elvisangelaccio retitled this revision from to Fix opening of archives whose mimetype cannot be detected-by-content.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio set the repository for this revision to R36 Ark.
elvisangelaccio added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptNov 28 2015, 5:14 PM
elvisangelaccio updated this revision to Diff 1420.Nov 28 2015, 5:19 PM
  • Add warning print
rthomsen accepted this revision.Dec 8 2015, 6:38 PM
rthomsen edited edge metadata.

If you have tested this, please Ship it!

This revision is now accepted and ready to land.Dec 8 2015, 6:38 PM

Revision Contents
Changeset List

PathPackages
Mkerfuffle/archive_kerfuffle.cpp (5 lines)

Diff 1420

View Options

kerfuffle/archive_kerfuffle.cpp

Loading...