QMake: Fix configure, also configure when needed
ClosedPublic

Authored by kfunk on Nov 28 2015, 2:50 PM.

Details

Summary

Changes:

  • Create build directory if it doesn't exist yet
  • When build dir does not exist:
    • Run qmake before build/install/clean
    • Run configure on import

Generally behaves a lot more like the CMake plugin now.

BUG: 320700
FIXED-IN: 5.0.0

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk updated this revision to Diff 1418.Nov 28 2015, 2:50 PM
kfunk retitled this revision from to QMake: Fix configure, also configure when needed.
kfunk updated this object.
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptNov 28 2015, 2:50 PM
mwolff accepted this revision.Dec 1 2015, 5:29 PM
mwolff added a reviewer: mwolff.
mwolff added a subscriber: mwolff.

lgtm, thanks!

projectmanagers/qmake/qmakeutils.h
42

rename to needsConfigure?

44

rename to query?

This revision is now accepted and ready to land.Dec 1 2015, 5:29 PM
kfunk added inline comments.Dec 2 2015, 8:53 PM
projectmanagers/qmake/qmakeutils.h
42

Trying to be consistent with naming from CMake here

44

Mine is more descriptive, IMO

This revision was automatically updated to reflect the committed changes.