This works fine, and the patch is very nice and complete. The one thing I'm not too fond of is the use of 'auto' -- there's not much advantage in using

auto layer = qobject_cast<KisLayer*>(active.data());

instead of

KisLayer *layer = qobject_cast<KisLayer*>(active.data());, or even in loops. It's not a big problem, though, and I'll push your patch after pushing https://phabricator.kde.org/D6139?id=15258#114876 -- weirdly enough, two people worked on the same thing at the same time. The author of the other patch spent a long time working on getting into Krita, so I'd like to have his name in our git history as well...

This revision is now accepted and ready to land.Jun 8 2017, 7:18 AM

Btw... I see this isn't your first patch for a KDE project: maybe you should get committer access?

Oh, that was unintentional coincidence, sorry, I didn't check the phabricator before submitting

It's probably too early for me to ask for a commit access because I have only a couple of patches accepted

Also, I assume it's okay to close this revision since the patch was accepted?

For me, 3 patches are enough :-). And yes, the revision should've been closed.

Revision Contents
Changeset List

			Path	Packages
M			krita/krita.action (48 lines)
M			libs/ui/kis_node_manager.h (5 lines)
M			libs/ui/kis_node_manager.cpp (80 lines)
M			plugins/dockers/defaultdockers/kis_layer_box.cpp (5 lines)