Differential D6099

Fix Aurorae decorations with non integer DPI
ClosedPublic
Actions

Authored by davidedmundson on Jun 5 2017, 7:51 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R108:5091feb8f603: Fix Aurorae decorations with non integer DPI
Summary

As noted by Thomas L we're casting the scaleFactor to an int far too
early, which in the worst case means we end up with Aurorare themes not
rendering.

This moves the rounding to where it's used per border.

BUG: 380524

Test Plan

Forced Xft.DPI to 95 with xrdb. Confirmed that it was broken
Applied this patch. Got decoration again

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidedmundson created this revision.Jun 5 2017, 7:51 AM
Restricted Application added a project: KWin. · View Herald TranscriptJun 5 2017, 7:51 AM
Restricted Application added subscribers: KWin, kwin, plasma-devel. · View Herald Transcript
mart accepted this revision.Jun 5 2017, 9:08 AM
mart added a subscriber: mart.

+1, this should fix https://bugs.kde.org/show_bug.cgi?id=380524 sorry for the introduced bug

This revision is now accepted and ready to land.Jun 5 2017, 9:08 AM
Closed by commit R108:5091feb8f603: Fix Aurorae decorations with non integer DPI (authored by davidedmundson). · Explain WhyJun 5 2017, 9:51 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 15158

View Options

plugins/kdecorations/aurorae/src/lib/themeconfig.cpp

Loading...