Differential D6094

Runtime Permissions: optional Permissions
ClosedPublic
Actions

Authored by nicolasfella on Jun 4 2017, 9:28 PM.

Details

Reviewers
albertvaka
Group Reviewers
KDE Connect
Commits
R225:34c84051c9e3: Runtime Permissions: optional Permissions
Summary

Added support for optional Permissions. Also provided explanations why the permissions are needed

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella created this revision.Jun 4 2017, 9:28 PM
albertvaka added a subscriber: albertvaka.Jun 22 2017, 9:11 PM
albertvaka added inline comments.
src/org/kde/kdeconnect/Plugins/TelephonyPlugin/TelephonyPlugin.java
296

I think this one only needs READ_SMS?

nicolasfella updated this revision to Diff 16461.Jul 10 2017, 5:51 PM

Changed SEND_SMS to READ_SMS

nicolasfella marked an inline comment as done.Jul 10 2017, 5:51 PM
albertvaka accepted this revision.Jul 10 2017, 10:15 PM
This revision is now accepted and ready to land.Jul 10 2017, 10:15 PM
Closed by commit R225:34c84051c9e3: Runtime Permissions: optional Permissions (authored by nicolasfella). · Explain WhyJul 11 2017, 7:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 16536

View Options

AndroidManifest.xml

Loading...
View Options

res/values/strings.xml

Loading...
View Options

src/org/kde/kdeconnect/Device.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/Plugin.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/SftpPlugin/SftpPlugin.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/SharePlugin/SharePlugin.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/TelepathyPlugin/TelepathyPlugin.java

Loading...
View Options

src/org/kde/kdeconnect/Plugins/TelephonyPlugin/TelephonyPlugin.java

Loading...
View Options

src/org/kde/kdeconnect/UserInterface/DeviceFragment.java

Loading...