Remove label of PrintProgressWidget
AbandonedPublic
Actions

Authored by laysrodrigues on Jun 3 2017, 7:24 PM.

Details

Reviewers

rizzitello
patrickelectric

Summary

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Update xml of gui setup

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Refactor of MainWindow

adding comments

Add new setup on initWidgets for the docks, also adding comments
On SetupActions:
- update _connect action to also close the connection
- Add a connect to update the toggle status of the _connect action when a connection isn't sucessful.
- Add comments
- Add actions for the plotDock, toolboxDock
- Remove action for the pushWidget
HandlePrinterStatusChanged:
- Change groupBox to toolBoxTaWidget
- Change printProgressWidget to printProgressDockWidget

to simulate the 3DView while ins't done.

Signed-off-by: Lays Rodrigues <laysrodriguessilva@gmail.com>

Branch

part3

Lint

No Linters Available

Unit

No Unit Test Coverage

src/mainwindow.cpp
50	Why in some places it have: /* * xxx / and in others: `/ xxx /` Be consistent, just use `/ xxx */`

rizzitello requested changes to this revision.Jun 4 2017, 4:12 AM

rizzitello added inline comments.

src/mainwindow.cpp
49	please use single line comment for slingle comment line //Start Connection to the 3DPrinter
112	This is not a KXMLGui issue as i had them working correctly before with KXMLGui in the Test client. Please fix this.
122	These should not be needed. I think they are both on by default
217	use the QDockWidget's ToggleView Action Action instead action = actionCollection()->addAction(QString("ActionNameFromRcFile),ui->plotDockWidget->toggleViewAction); this is the proper actions to show / hide docks with KXMLGUI

This revision now requires changes to proceed.Jun 4 2017, 4:12 AM

			Path	Packages
M			deploy/atelierui.rc (2 lines)
M			src/mainwindow.h (1 line)
M			src/mainwindow.cpp (129 lines)
M			src/mainwindow.ui (198 lines)
M			src/widgets/printprogresswidget.cpp (2 lines)

Commit	Tree	Parents	Author	Summary	Date
332a2961b3da	0e5ef4363109	b9efb5c8542c	Lays Rodrigues	Refactor of MainWindow (Show More…)	Jun 3 2017, 6:29 PM
b9efb5c8542c	2a873a23b09d	4d01b9701ef0	Lays Rodrigues	Update xml of gui setup (Show More…)	Jun 3 2017, 6:25 PM
4d01b9701ef0	8934686109de	0ed4396c315f	Lays Rodrigues	Remove label of PrintProgressWidget (Show More…)	Jun 3 2017, 5:45 PM