- Set up the connection between Cantor and qalc
- Use streams for I/O
- Parse the output returned by qalc
- Segregate API dependent parts fromqalc
- Use expression queue and command queue for commands that are to be processed by qalc
- use qalc for saving variables
- update variable model
You should comment out this line. It's only for testing isn't it?
this and also others following this.
IF cantor uses Qt5 then why not switch to QRegularExpression? IIRC it provides some improvements over QRegExp.
I think return currentCmd.clear() also does the same thing
Use QStringLiteral("...").arg(...) instead.
Do something like this
currentCmd = QStringLiteral(...).arg(...); return currentCmd;
Use currentCmd + QStringLiteral combination.
return QString();, though both are same.
Hi Rishabh, your patch looks ok for me. The previous reviewer pointed some interesting questions, please address them except by those related to comments to follow debug, sometimes it is usual.
I am keeping the debug statements for now.
Thanks for pointing out .
Yes. I don't know why I did this
Correct. QStringLiteral is less expensive as pointed out here
Unfortunately we are not able to use or or and expressions yet, so change it to old logic operators syntax.
In addition, could you provide parentheses for this verification? It is really bad to read (and it is creating an error message during building).
I have made the changes and If everything looks good to you, I'll push the changes
I have changed the logic here a bit and have tried to improve the overall readability.
There were no build errors on my side. Please check if the new code works fine on your system