Differential D6040

Adding the 'setUnits' function
ClosedPublic
Actions

Authored by cdelima on May 30 2017, 11:16 PM.

Details

Reviewers
patrickelectric
rizzitello
laysrodrigues
Group Reviewers
Atelier: AtCore
Commits
R232:835e120e3684: Adding the 'setUnits' function
Summary

Added the function per se, an enum for the metric system, and the function declaration.

Diff Detail

Repository
R232 AtCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
cdelima created this revision.May 30 2017, 11:16 PM
patrickelectric accepted this revision.May 30 2017, 11:17 PM
This revision is now accepted and ready to land.May 30 2017, 11:17 PM
rizzitello added a subscriber: rizzitello.May 31 2017, 1:03 AM
rizzitello added inline comments.
src/atcore.h
56

MesurementUnits? UnitsOfMesure, notsure exactly but MetricSystem is a poor name only because it doesn't describe what the enum is for only one of the choices.

57

ALL Enums should be full caps 'METRIC' , 'IMPERIAL'

276

void setUnits(MetricSystem units)
we are setting units that as the varible the function takes. .

rizzitello requested changes to this revision.May 31 2017, 1:03 AM
This revision now requires changes to proceed.May 31 2017, 1:03 AM
cdelima updated this revision to Diff 15053.Jun 1 2017, 3:09 PM
cdelima edited edge metadata.

Corrected the unit names

rizzitello accepted this revision.Jun 1 2017, 3:28 PM
This revision is now accepted and ready to land.Jun 1 2017, 3:28 PM
laysrodrigues accepted this revision.Jun 1 2017, 7:05 PM
Closed by commit R232:835e120e3684: Adding the 'setUnits' function (authored by rizzitello). · Explain WhyJun 2 2017, 1:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/atcore.h (10 lines)
Msrc/atcore.cpp (10 lines)

Diff 15070

View Options

src/atcore.h

Loading...
View Options

src/atcore.cpp

Loading...