| dvratil |
Flags are provided with a default mimetype of emails,
and we want to avoid creating email items if a flag of a
groupware item changed.
notes from randa:
-> you are talking about kdepimlibs/akonadi/job/itemcreatejob ? -> I see there no assert.
-> I do not understand
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Makes sense. It should not be possible to have multiple items with same RID in one collection, so removing the mimetype condition there does not make any change.
We already learned that GID-based merge is dangerous and can have conflicts, so weakening the constraint by removing the mimetype probably increases the chance of a conflict (it's possible to have multiple items with the same GID but different mime types in a single collections), but that's why we switched to RID merge and use GID only as a fallback .