Use existing parseInt function
AbandonedPublic

Authored by davidedmundson on May 30 2017, 2:25 PM.

Details

Reviewers
sebas
Group Reviewers
Plasma
Summary

There's already a QString::toInt() that validates input. We don't need
to make our own.

Also there was a bug in the current point parsing code if the first was
invalid but the second valid. Both need to be checked.

Test Plan

Compiles

Diff Detail

Repository
R110 KScreen Library
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson created this revision.May 30 2017, 2:25 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 30 2017, 2:25 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
sebas added a subscriber: sebas.Aug 24 2017, 9:55 AM

This one slipped my attention. I think it's still relevant?

src/doctor/doctor.h
54

Unrelated?

sebas requested changes to this revision.Aug 28 2017, 2:43 PM
This revision now requires changes to proceed.Aug 28 2017, 2:43 PM
sebas resigned from this revision.Sep 20 2017, 8:58 AM

Please abandon, I've already fixed this in master.

davidedmundson abandoned this revision.Sep 20 2017, 8:58 AM