Differential D602

LIST: list referenced/enabled status of ancestors.
ClosedPublic
Actions

Authored by knauss on Nov 27 2015, 4:06 PM.

Details

Reviewers
dvratil
Maniphest Tasks
T1110: merge kolab akonadi changes
Commits
R165:08dea308e58a: LIST: list referenced/enabled status of ancestors.
Summary

This is required so clients don't have to refetch
ancestors for i.e. updates provided by the monitor.

Usecase currently in zanshin.

notes from randa:

  • Port to new protocol

-> it compiles and also the CollectionAttributes are still the same, so don't know what is meant with new protocol

Diff Detail

Repository
R165 Akonadi
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
knauss updated this revision to Diff 1398.Nov 27 2015, 4:06 PM
knauss retitled this revision from to LIST: list referenced/enabled status of ancestors..
knauss updated this object.
knauss edited the test plan for this revision. (Show Details)
knauss added a reviewer: dvratil.
knauss added a task: T1110: merge kolab akonadi changes .
dvratil edited edge metadata.Dec 5 2015, 6:35 PM

Looks good. Could you please add a comment to the code explaining why we send the attributes?

Do you think you could extend a kdepimlibs unit-tests (probably CollectionJobTest)?

dvratil accepted this revision.Mar 16 2016, 12:05 PM
dvratil edited edge metadata.
This revision is now accepted and ready to land.Mar 16 2016, 12:05 PM
Closed by commit R165:08dea308e58a: LIST: list referenced/enabled status of ancestors. (authored by cmollekopf, committed by knauss). · Explain WhyMar 16 2016, 12:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/server/handler/list.cpp (17 lines)

Diff 2798

View Options

src/server/handler/list.cpp

Loading...