ApplicationModel takes ownership of PageModels
ClosedPublic

Authored by ervin on Nov 25 2015, 4:44 PM.

Details

Summary

The ownership was misguided before and stayed with whoever create the
page (likely the available pages model). It caused two issues:

  • constant memory increase since the available pages model didn't know when a page model wasn't necessary;
  • sometimes crash on exit.

Now ApplicationModel forcibly takes ownership and manage this sub-model
using a shared pointer like the other ones. Way more consistent and
predictible.

Diff Detail

Repository
R4 Zanshin
Lint
Lint Skipped
Unit
Unit Tests Skipped
ervin updated this revision to Diff 1390.Nov 25 2015, 4:44 PM
ervin retitled this revision from to ApplicationModel takes ownership of PageModels.
ervin updated this object.
ervin edited the test plan for this revision. (Show Details)
ervin added reviewers: bensi, franckarrecot.
bensi accepted this revision.Nov 25 2015, 4:46 PM
bensi edited edge metadata.
This revision is now accepted and ready to land.Nov 25 2015, 4:46 PM
This revision was automatically updated to reflect the committed changes.