Port the Group dialog widget. Was missed from the Qt5 porting.

Authored by piggz on May 23 2017, 9:55 PM.



Make the group dialog work in Qt5

Test Plan

Build, open kreportexample and add/edit/remove group sections

Diff Detail

R14 KReport
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
piggz created this revision.May 23 2017, 9:55 PM
Restricted Application added a project: KReport. · View Herald TranscriptMay 23 2017, 9:55 PM
staniek edited edge metadata.EditedMay 24 2017, 9:35 AM
  • Fix dialog margins (shall be like in Help->About Kexi for example), to do this just reset values of the layout*Margin properties in Designer for the DetailGroupSectionDialog widget

  • Base branch for this patch shall be 3.0. Then we would merge to master.
  • Extra: set buddy for the three check boxes (clicking on the labels is still broken even if you set StrongFocus for them but this may be due to the issue with Breeze style)
staniek requested changes to this revision.May 24 2017, 9:42 AM
staniek added inline comments.

Not needed


Not needed

This revision now requires changes to proceed.May 24 2017, 9:42 AM
piggz updated this revision to Diff 14814.May 24 2017, 6:11 PM
piggz edited edge metadata.
  • Address review comments.
staniek accepted this revision.May 24 2017, 6:32 PM

Good. Please don't forget to commit to 3.0 first. To do that e.g. cherry-pick the commit on 3.0, then arc-land or git push.
Then git merge to master.

This revision is now accepted and ready to land.May 24 2017, 6:32 PM
This revision was automatically updated to reflect the committed changes.
piggz marked 2 inline comments as done.