Differential D5843

Do not use QtModule/QtClass includes
ClosedPublic
Actions

Authored by ervin on May 13 2017, 4:56 PM.

Details

Reviewers
dfaure
bensi
franckarrecot
Group Reviewers
Zanshin
Commits
R4:2bf393eedcea: Do not use QtModule/QtClass includes
Summary

Found by Krazy.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin created this revision.May 13 2017, 4:56 PM
dfaure accepted this revision.May 13 2017, 5:01 PM
dfaure added inline comments.
tests/testlib/modeltest.cpp
43–44

urgh.

This revision is now accepted and ready to land.May 13 2017, 5:01 PM
ervin updated this revision to Diff 14485.May 13 2017, 5:06 PM

Get rid of QtGui include

dfaure added inline comments.May 13 2017, 5:56 PM
tests/testlib/modeltest.cpp
44

well, still urgh (QtTest includes all of QtCore).

ervin marked an inline comment as done.May 15 2017, 2:10 PM
ervin added inline comments.
tests/testlib/modeltest.cpp
43–44

Right, can probably live without it... I'll try.

ervin updated this revision to Diff 14549.May 15 2017, 2:48 PM

Address dfaure's comments

dfaure accepted this revision.May 15 2017, 4:50 PM
bensi accepted this revision.May 16 2017, 7:18 AM
Closed by commit R4:2bf393eedcea: Do not use QtModule/QtClass includes (authored by ervin). · Explain WhyJun 2 2017, 12:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 15088

View Options

tests/testlib/modeltest.h

Loading...
View Options

tests/testlib/modeltest.cpp

Loading...