Details
- Reviewers
dfaure bensi franckarrecot - Group Reviewers
Zanshin - Commits
- R4:e49cb599ec42: Implement caching for the collection fetches
Diff Detail
- Repository
- R4 Zanshin
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
| src/akonadi/akonadicachingstorage.cpp | ||
|---|---|---|
| 35 | CachingCollectionFetchJob would be a better name, I would think. | |
| 56 | I'm curious, why did you earlier commit use Q_DECL_OVERRIDE and this one uses override ? | |
| 83 | I guess this could be a copy_if, to integrate the "<<" that happens below? | |
| 120 | KCompositeJob's slotResult would do this for you, if this job inherited KCompositeJob. | |
| 130 | I'm curious, why the explicit detach? | |
| src/akonadi/akonadicachingstorage.cpp | ||
|---|---|---|
| 56 | No particular reason apart from reusing code wrote way before 5.7 was around which makes override support necessary. I'm even thinking moving the whole codebase away from Q_DECL_OVERRIDE and Q_NULLPTR at that point. Opinion? | |
| 83 | Except that copy_if would carry on for the whole collection, I'd rather have it stop iterating at the first matching one, hence the find_if. | |
| 130 | Left over from a time when I was chasing a ghost. | |
| src/akonadi/akonadicachingstorage.cpp | ||
|---|---|---|
| 121 | You forgot to call KCompositeJob::slotResult(kjob) here. It takes care of setting the error code+text and of calling emitResult(). | |