bookmark collection feature
ClosedPublic
Actions

Authored by ervin on May 13 2017, 4:02 PM.

Details

Reviewers

dfaure
bensi
franckarrecot

Group Reviewers

Zanshin

Commits

R4:61f41fb529fe: Remove the unused list/unlist/bookmark collection feature

Summary

This was introduced during 0.3 times for a specific Munich request. Was
never used otherwise and even unreachable from the GUI by the user
except when a specific flag was set. Needless to say it had plenty of
time to rot and break without us noticing. Time to clean it up.

Diff Detail

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin created this revision.May 13 2017, 4:02 PM

Talk about spring cleaning ;)

This revision is now accepted and ready to land.May 13 2017, 4:49 PM

bensi accepted this revision.May 16 2017, 8:03 AM

Closed by commit R4:61f41fb529fe: Remove the unused list/unlist/bookmark collection feature (authored by ervin). · Explain WhyJun 2 2017, 12:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		src/akonadi/CMakeLists.txt (1 line)
M		src/akonadi/akonadicollectionfetchjobinterface.h (1 line)
D	M	src/akonadi/akonadicollectionsearchjobinterface.h (46 lines)
D	M	src/akonadi/akonadicollectionsearchjobinterface.cpp (44 lines)
M		src/akonadi/akonadidatasourcequeries.h (9 lines)
M		src/akonadi/akonadidatasourcequeries.cpp (46 lines)
M		src/akonadi/akonadilivequeryhelpers.h (2 lines)
M		src/akonadi/akonadilivequeryhelpers.cpp (31 lines)
M		src/akonadi/akonadiserializer.h (1 line)
M		src/akonadi/akonadiserializer.cpp (33 lines)
M		src/akonadi/akonadiserializerinterface.h (1 line)
M		src/akonadi/akonadistorage.h (1 line)
M		src/akonadi/akonadistorage.cpp (90 lines)
M		src/akonadi/akonadistorageinterface.h (2 lines)
M		src/domain/datasource.h (14 lines)
M		src/domain/datasource.cpp (15 lines)
M		src/domain/datasourcequeries.h (5 lines)
M		src/presentation/availablesourcesmodel.h (15 lines)
M		src/presentation/availablesourcesmodel.cpp (107 lines)
M		src/widgets/availablesourcesview.h (2 lines)
M		src/widgets/availablesourcesview.cpp (46 lines)
M		src/widgets/datasourcedelegate.h (21 lines)
M		src/widgets/datasourcedelegate.cpp (140 lines)
M		tests/testlib/akonadifakejobs.h (18 lines)
M		tests/testlib/akonadifakejobs.cpp (20 lines)
M		tests/testlib/akonadifakestorage.h (1 line)
M		tests/testlib/akonadifakestorage.cpp (37 lines)
M		tests/testlib/akonadistoragetestbase.h (6 lines)
M		tests/testlib/akonadistoragetestbase.cpp (231 lines)
M		tests/testlib/gencollection.h (2 lines)
M		tests/testlib/gencollection.cpp (12 lines)
M		tests/units/akonadi/akonadidatasourcequeriestest.cpp (618 lines)
M		tests/units/akonadi/akonadilivequeryhelperstest.cpp (234 lines)
M		tests/units/akonadi/akonadinotequeriestest.cpp (2 lines)
M		tests/units/akonadi/akonadiserializertest.cpp (140 lines)
M		tests/units/akonadi/akonaditaskqueriestest.cpp (2 lines)
M		tests/units/domain/datasourcetest.cpp (20 lines)
M		tests/units/presentation/availablesourcesmodeltest.cpp (304 lines)
M		tests/units/testlib/gencollectiontest.cpp (30 lines)
M		tests/units/widgets/CMakeLists.txt (1 line)
M		tests/units/widgets/availablesourcesviewtest.cpp (180 lines)
D	M	tests/units/widgets/datasourcedelegatetest.cpp (150 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14468	9671d1e		May 13 2017, 4:02 PM	★	★
Diff 2	15090	2bf393e	R4:61f41fb529fe4a9a8b7e2879d9b5f9dc2fd6bccb	Jun 2 2017, 10:18 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
3806075ccd73	62f44f4b0421	9671d1eb0848	Kevin Ottens	Remove the unused list/unlist/bookmark collection feature (Show More…)	Apr 16 2017, 1:34 PM

Remove the unused list/unlist/bookmark collection featureClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 15090

src/akonadi/CMakeLists.txt

src/akonadi/akonadicollectionfetchjobinterface.h

src/akonadi/akonadicollectionsearchjobinterface.h

src/akonadi/akonadicollectionsearchjobinterface.cpp

src/akonadi/akonadidatasourcequeries.h

src/akonadi/akonadidatasourcequeries.cpp

src/akonadi/akonadilivequeryhelpers.h

src/akonadi/akonadilivequeryhelpers.cpp

src/akonadi/akonadiserializer.h

src/akonadi/akonadiserializer.cpp

src/akonadi/akonadiserializerinterface.h

src/akonadi/akonadistorage.h

src/akonadi/akonadistorage.cpp

src/akonadi/akonadistorageinterface.h

src/domain/datasource.h

src/domain/datasource.cpp

src/domain/datasourcequeries.h

src/presentation/availablesourcesmodel.h

src/presentation/availablesourcesmodel.cpp

src/widgets/availablesourcesview.h

src/widgets/availablesourcesview.cpp

src/widgets/datasourcedelegate.h

src/widgets/datasourcedelegate.cpp

tests/testlib/akonadifakejobs.h

tests/testlib/akonadifakejobs.cpp

tests/testlib/akonadifakestorage.h

tests/testlib/akonadifakestorage.cpp

tests/testlib/akonadistoragetestbase.h

tests/testlib/akonadistoragetestbase.cpp

tests/testlib/gencollection.h

tests/testlib/gencollection.cpp

tests/units/akonadi/akonadidatasourcequeriestest.cpp

tests/units/akonadi/akonadilivequeryhelperstest.cpp

tests/units/akonadi/akonadinotequeriestest.cpp

tests/units/akonadi/akonadiserializertest.cpp

tests/units/akonadi/akonaditaskqueriestest.cpp

tests/units/domain/datasourcetest.cpp

tests/units/presentation/availablesourcesmodeltest.cpp

tests/units/testlib/gencollectiontest.cpp

tests/units/widgets/CMakeLists.txt

tests/units/widgets/availablesourcesviewtest.cpp

tests/units/widgets/datasourcedelegatetest.cpp

Remove the unused list/unlist/bookmark collection feature
ClosedPublic
Actions

Revision Contents
Changeset List