Details
Details
- Reviewers
vhanda kfunk - Group Reviewers
KDevelop - Commits
- R32:c449c5bc663d: Expose a method to open projects to dbus
R33:c449c5bc663d: Expose a method to open projects to dbus
Diff Detail
Diff Detail
- Repository
- R33 KDevPlatform
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Please use one of the static methods to construct the QUrl, e.g. QUrl::fromUserInput. More explicit.
I'm actually surprised this code compiles, we define QT_NO_URL_CAST_FROM_STRING already(?)
Comment Actions
I don't know if that's a good idea. This QString overload is just for dbus who should already be sending proper QUrl but dbus sucks at QUrl, so QString is better, but I wouldn't process it as a path but as a QUrl.
Note this url is already being processed in kdevelop side.