Workaround for MSVC and catalog loading
ClosedPublic

Authored by ltoscano on May 6 2017, 12:57 AM.

Details

Summary

Apparently setting XML_CATALOG_FILES has no effects on Windows
at least with MSVC (2017). The variable seems to be set, so
there may be an issue with the linking, or in libxml2, or
in some other unidentified place. Forcibly setting the
catalog seems to work, but let's leave it as a special case
on MSVC only for now.

Test Plan

Tested on the new CI, tested a package with documentation
(kconfigwidgets)

Diff Detail

Repository
R238 KDocTools
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ltoscano created this revision.May 6 2017, 12:57 AM
Restricted Application added projects: Frameworks, Documentation. · View Herald TranscriptMay 6 2017, 12:57 AM
Restricted Application added subscribers: Documentation, Frameworks. · View Herald Transcript
ltoscano updated this revision to Diff 14182.May 6 2017, 1:02 AM

Readd docs

@bcooksley , is there a way to test this properly in the new CI (aka: without me manually applying some patches), to see if I didn't do something weird that made it work by accident?

Unfortunately our Jenkins Jobs aren't configured to apply patches, so there isn't a way of testing this as such other than through:

  1. Some manual handling
  2. Committing it and seeing what happens.
bcooksley accepted this revision.May 6 2017, 11:12 AM

Code looks fine from my perspective, let's confirm this fixes things.

This revision is now accepted and ready to land.May 6 2017, 11:12 AM
This revision was automatically updated to reflect the committed changes.