AppMenu: Don't call AboutToShow on LayoutUpdated

Authored by drosca on May 3 2017, 8:06 PM.



This workaround is there (according to the comment) for Firefox,
but I still don't get any appmenu in Firefox at all.
It breaks applications that rely on aboutToShow/aboutToHide signals,
because it sends aboutToShow to all menus on startup without actually
the menu being opened.

BUG: 375053

Test Plan

Fixes linked bug.
MenuImporter::fakeUnityAboutToShow is now no longer used, so if this fix is accepted,
the patch should be changed to remove the whole function and connections instead of
just commenting the call.

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
drosca created this revision.May 3 2017, 8:06 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 3 2017, 8:06 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Any comments on this? It is still broken.

davidedmundson accepted this revision.Jul 14 2017, 9:38 AM
davidedmundson added a subscriber: davidedmundson.

If something is worth deleting, it's worth deleting properly. Kill the whole method.
We can always revert it.

This revision is now accepted and ready to land.Jul 14 2017, 9:38 AM
This revision was automatically updated to reflect the committed changes.