Do not extract all template preview images, load from archives on demand

Authored by kossebau on May 3 2017, 6:50 PM.



Saves disk space, IO and avoids garbage preview files due to no
existing garbage collector.
Ideally description files would also not be extracted,
but KDesktopFile code sadly does not work against QIODevice.

Test Plan

Previews work as before in the app wizard.
No direct idea for a unit test, unless extending API
of TemplatePreviewIcon just for that need.

Diff Detail

R33 KDevPlatform
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.May 3 2017, 6:50 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMay 3 2017, 6:50 PM
apol added a subscriber: apol.May 4 2017, 10:23 AM
apol added inline comments.

Can we change the name entirely then?
It's not an icon after all.


use angle brackets for the include

kossebau updated this revision to Diff 14130.May 4 2017, 11:43 AM
kossebau marked 2 inline comments as done.

fix brackets for include, rename role for preview

@apol: this new version okay? would not mind to get this into 5.1.1 as well, to prevent further pollution of users' share/ folders :)

This revision was automatically updated to reflect the committed changes.