Possible fix for T668

Authored by piggz on May 3 2017, 6:39 PM.



Always save the script, regardless of whether or not the object script
is empty, this way and default to the original script, unless the object
script has been changed. This way, the original interpreter should be
saved, unless the object script is changed

Test Plan
  1. open a report with a python interpreter
  2. edit the report with an innocuous change (alter section height)
  3. save report, confirm on debug output that the interpreter is still python
  4. edit the report and change the script source
  5. save, confirm the interpreter is now javascript

Diff Detail

R14 KReport
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
piggz created this revision.May 3 2017, 6:39 PM
Restricted Application added a project: KReport. · View Herald TranscriptMay 3 2017, 6:39 PM
piggz updated this revision to Diff 14128.May 3 2017, 9:33 PM

Also set interpreter if the original is empty

staniek accepted this revision.May 4 2017, 12:17 PM
staniek edited the test plan for this revision. (Show Details)

Good job

This revision is now accepted and ready to land.May 4 2017, 12:17 PM

To 3.0 and master, right?

This revision was automatically updated to reflect the committed changes.