Solve a visibility conflict for meinproc5
ClosedPublic

Authored by ltoscano on Apr 30 2017, 9:36 PM.

Details

Summary

This seems to affect only mingw, which can't link meinproc5 as
the symbol exported affects in the sources shared with the
library affects the build (but not on gcc on *nix and with MSVC).

The other (probably better) solution would have been to split the
source code so that the sources of the libraries are separate, but
that would require more changes. As this seems to work, I'd prefer
to move the more complicated changes to "later".

Thanks to Hannah Von Reth for the hint.

BUG: 379142

Test Plan

Compiles with gcc 6.3 (Debian Testing), as before), with mingw (as deployed on current Craft) and with MSVC (2017) (the latter with less linking warnings so it was an issue there). All on x86_64.

Diff Detail

Repository
R238 KDocTools
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ltoscano created this revision.Apr 30 2017, 9:36 PM
Restricted Application added projects: Frameworks, Documentation. · View Herald TranscriptApr 30 2017, 9:36 PM
Restricted Application added subscribers: Documentation, Frameworks. · View Herald Transcript
ltoscano removed a subscriber: Windows.
ltoscano edited the test plan for this revision. (Show Details)Apr 30 2017, 10:11 PM
vonreth accepted this revision.May 2 2017, 3:21 PM
This revision is now accepted and ready to land.May 2 2017, 3:21 PM
This revision was automatically updated to reflect the committed changes.