Prevent drop events to non-local destinations
ClosedPublic

Authored by elvisangelaccio on Nov 21 2015, 2:13 PM.

Details

Summary

We already prevent users from extracting to a non-local destination, when they use a KFileWidget. The same should be done when they drag-and-drop to a non-local destination in e.g. Dolphin. Currently the extraction is performed into the current directory, which is not expected.

CCBUG: 204323

Test Plan

Drag-and-dropping to e.g. trash:/ now results in a warning message and no ExtractJob is started. Drag-and-dropping to local destinations still works.

Diff Detail

Repository
R36 Ark
Branch
no-remote-drops
Lint
No Linters Available
Unit
No Unit Test Coverage
elvisangelaccio retitled this revision from to Prevent drop events to non-local destinations.
elvisangelaccio updated this object.
elvisangelaccio edited the test plan for this revision. (Show Details)
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio set the repository for this revision to R36 Ark.
elvisangelaccio added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel. · View Herald TranscriptNov 21 2015, 2:13 PM
  • Merge branch 'Applications/15.12' into no-remote-drops
  • Incorporate Eike's patch
rthomsen accepted this revision.Dec 8 2015, 6:46 PM
rthomsen edited edge metadata.

If you have tested this, please Ship it!

This revision is now accepted and ready to land.Dec 8 2015, 6:46 PM
This revision was automatically updated to reflect the committed changes.