On OSX, with XCode's clang, the code browser would show "std::string" being a part of container "__1" (implementation detail of libc++ I believe)
Clicking this "__1" crashed, repeatably.
This fix simply checks if the value is null, and does not try to access it.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| language/duchain/navigation/abstractnavigationcontext.cpp | ||
|---|---|---|
| 234–236 | Please advise if the "else" return value is appropriate. | |
lgtm as a hotfix
| language/duchain/navigation/abstractnavigationcontext.cpp | ||
|---|---|---|
| 227–228 | could we maybe fix this for real? the code is evil indeed... maybe something for the future though | |
| 234–236 | phew - good question. is the behavior in the case where it crashed before OK now? what happens when you return {};? | |
| language/duchain/navigation/abstractnavigationcontext.cpp | ||
|---|---|---|
| 234–236 | return {};has the same effect as return NavigationContextPointer(this); That said, the original author always used the latter in other contexts in the calling function, so I am sticking with the same pattern. As for the behavior, it simply doesn't crash now. Clicking the "__1" has no effect now. | |