Remove Q_SCRIPTABLE tags not used for D-Bus or QML (no more Kross support)
ClosedPublic

Authored by kossebau on Apr 26 2017, 4:49 PM.

Details

Summary

There were lots of Q_SCRIPTABLE tags which once were added for Kross,
but no longer serve any purpose, besides a few being picked up/reused
for interfaces exposed to QML or D-Bus.

This patch removes any such tags which were not used or useful (due
to incomplete types) from QML and D-Bus.
For access to KDevelop::ICore's projectController from QML instead
a QObject property is now noted. And the methods of IProjectController
used from QML are tagged as Q_INVOKABLE, so they are not included
in the D-Bus interface.

It will also remove the console warnings during start-up
"
Invalid return type in method "core"
"
which are from method generateInterfaceXml(...) in
qtbase/src/dbus/qdbusxmlgenerator.cpp when it generates
the interface for ExternalScriptPlugin, which inherits
KDevelop::IPlugin, which had its method
ICore *core() const; tagged with Q_SCRIPTABLE,
and as the ExternalScriptPlugin registers itself as
object to the bus using QDBusConnection::ExportScriptableSlots
that method was included in the interface, but without ICore*
being known.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kossebau created this revision.Apr 26 2017, 4:49 PM
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptApr 26 2017, 4:49 PM
apol accepted this revision.Apr 26 2017, 5:28 PM
This revision is now accepted and ready to land.Apr 26 2017, 5:28 PM
This revision was automatically updated to reflect the committed changes.