The patch fixes:
- Error message about QLocalSocket::ServerNotFoundError when we try to connect to socket which is not already created by cmake server process.
- Error message about cmake server process crashing when we kill it in the destructor.
Details
Details
- Reviewers
apol - Commits
- R32:c3b02cdeff62: Small fixes in cmake server logic
Tested on master branch
Diff Detail
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Just checking this commit didn't introduce a potential issue that'll be a RPITA to debug.
| projectmanagers/cmake/cmakeserver.cpp | ||
|---|---|---|
| 77 | Is it certain that we aren't disconnecting QObject::destroyed signals here that should not be disconnected before m_process is actually destroyed? I too did a disconnect() in a dtor thinking it was a prudent thing to do. All was fine for months until I ran into an application that crashed systematically on exit, accessing a stale QObject. | |