SFTP ioslave: Port away from KDELibs4Support

Authored by marten on Apr 24 2017, 3:35 PM.



This change removes the build and runtime requirement for KDELibs4Support from the SFTP ioslave.

Test Plan

Built kio-extras with this change, checked correct operation of ioslave and access to remote hosts via SFTP.

Diff Detail

R320 KIO Extras
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
marten created this revision.Apr 24 2017, 3:35 PM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 24 2017, 3:35 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
dfaure requested changes to this revision.Apr 30 2017, 2:46 PM
dfaure added inline comments.

This should store the return value from openPasswordDialogV2 and use it in the error call 3 lines below, that's the whole point of the port to V2.

Same for the calls above, if possible (the patch doesn't show what the error handling is).

This revision now requires changes to proceed.Apr 30 2017, 2:46 PM
marten updated this revision to Diff 14036.Apr 30 2017, 5:56 PM
marten edited edge metadata.

There seems to be only one place where the result from the openPasswordDialog is actually propagated to the outside. I've changed this one; the point of changing the others was to port away from the old deprecated function.

dfaure accepted this revision.Apr 30 2017, 6:07 PM
This revision is now accepted and ready to land.Apr 30 2017, 6:07 PM
This revision was automatically updated to reflect the committed changes.