Add reset button for Curve widget options.
ClosedPublic

Authored by anikethgirish on Apr 24 2017, 2:00 PM.

Details

Diff Detail

Repository
R503 Krita Extension - Color Transformation Language
Lint
Lint Skipped
Unit
Unit Tests Skipped
anikethgirish created this revision.Apr 24 2017, 2:00 PM
anikethgirish added a reviewer: scottpetrovic.

Whenever I click the "reset" button, nothing seems to happen. Does it do anything when you press it?

anikethgirish added a reviewer: rempt.

Just tested that out and it resets the shape of the curve to the default. Looks good

@scottpetrovic All cool then. What about the alignment of the button. Hope that is fine. Else we can rearrange it accordingly :)

We could move the reset button underneath the curve widget. Right now it is below the settings and a bit more confusing on what it is changing

This comment was removed by anikethgirish.

Just tested it out and it looks good where it is. I am ok with this patch. Not sure if boud had any other comments

@scottpetrovic, okay nice. We can work on the next button you were talking about. yeah, we can wait for @rempt's response.

scottpetrovic accepted this revision.Apr 26 2017, 5:55 PM

I think this guy is good. Aniketh doesn't have commit access, so I will push this to master on his behalf

This revision is now accepted and ready to land.Apr 26 2017, 5:55 PM
scottpetrovic closed this revision.Sep 16 2017, 2:38 PM

this was pushed. closing