Differential D5550

Fix property changes being missed immediately after an obejct is added
ClosedPublic
Actions

Authored by drosca on Apr 23 2017, 1:12 PM.

Details

Reviewers

None

Group Reviewers

Frameworks

Commits

R269:c02c4806c9bf: Fix property changes being missed immediately after an obejct is added

Summary

Fix race condition when property changes may be missed if the property
is changed immediately after the object is created.
The issue was that the connection to PropertyChanged signal was
created only after interfacesAdded signal was fired, which may have
already been too late.
This fixes it with connecting to PropertyChanged signal on all paths
in Manager::init().

BUG: 377405

Test Plan

Added test pass + old tests still pass

Diff Detail

Repository

R269 BluezQt

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

drosca created this revision.Apr 23 2017, 1:12 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptApr 23 2017, 1:12 PM

Closed by commit R269:c02c4806c9bf: Fix property changes being missed immediately after an obejct is added (authored by drosca). · Explain WhyMay 26 2017, 12:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/fakebluez/devicemanager.h (1 line)
M			autotests/fakebluez/devicemanager.cpp (19 lines)
M			autotests/managertest.h (1 line)
M			autotests/managertest.cpp (20 lines)
M			src/adapter_p.cpp (8 lines)
M			src/device_p.cpp (10 lines)
M			src/input.cpp (10 lines)
M			src/input_p.h (4 lines)
M			src/manager_p.h (4 lines)
M			src/manager_p.cpp (27 lines)
M			src/mediaplayer_p.cpp (3 lines)
M			src/utils.h (1 line)
M			src/utils.cpp (7 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	13715	d4c1a21		Apr 23 2017, 1:12 PM	★	★
Diff 2	14855	ebcc2fb	R269:c02c4806c9bfcd6dc36fab6ed9873cff86681cdd	May 26 2017, 12:05 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
010b2c537b7b	b8bdd3c4f520	d4c1a21814c5	David Rosca	Fix property changes being missed immediately after an obejct is added (Show More…)	Apr 23 2017, 1:09 PM