We never check if a destination directory is writable, while doing an ExtractJob.
We can do this check only once, in ExtractJob::doWork(), instead of doing it
in each plugin's copyFiles(). This way we don't even start a cli process which
we already know is going to fail.
The only downside is that in batch mode (ark -b) the error message is displayed
twice, once in a KMessageBox and once in a Plasma notification.
BUG: 192219
FIXED-IN: 15.12.0
Trying to extract any kind of archive in a non-writable directory triggers the
error messagebox.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Update the diff (with an old-style patch, since apparently arcanist defaults to create diffs with respect to master)
Check also for destination directories which are writable but not executable. Update also the error message accordingly.
| kerfuffle/jobs.cpp | ||
|---|---|---|
| 271 | "the right permissions" -> "sufficient permissions" | |