Differential D5481

[Media Controller] Use double for length instead of int
ClosedPublic
Actions

Authored by broulik on Apr 17 2017, 11:42 AM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Summary

Length is in microseconds, so watching a long video (in excess of 33.3 minutes) will break the slider.

CHANGELOG: Media Controller can now properly handle and seek long tracks (> 30 minutes)

BUG: 377623
FIXED-IN: 5.8.7

Test Plan

Started couple of 45 minute videos, before that, opening media controller would unwind the video and have no seek slider. With this patch it works fine.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Apr 17 2017, 11:42 AM
Restricted Application added a project: Plasma. · View Herald TranscriptApr 17 2017, 11:42 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik edited the summary of this revision. (Show Details)Apr 17 2017, 11:44 AM
davidedmundson accepted this revision.Apr 17 2017, 2:11 PM
This revision is now accepted and ready to land.Apr 17 2017, 2:11 PM

Revision Contents
Changeset List

Diff 13527

View Options

applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

Loading...