I don't quite like the KReportPageSize namespace. It's still not only about page *sizes* but also formats.

First, let's look what are the differences to what the QPageSize delivers. More formats?

PS: "A4" translated name feels more user-friendly than "ISO A4".

How about using @return here and in each function below?

There's QPageSize::name() which defined translated strings as names. How about using pageNames()?

There's QPageSize::key() which defines page format strings as keys. How about using pageKeys()?

Inconsistent. "format name" term used above in pageFormatNames(), and here "string".

I propose a change.

Extra lines not needed...

I don't quite understand this simplicity -- setDpi() sets m_dpiY but m_dpiY can't be accessed... Do we need the m_dpiY attr then?

List -> list

don't

-> pageFormatNames()

(synced the term with the QPageSize API)

-> pageFormatKeys()

(synced the term with the QPageSize API)

I propose change to:

/**

• @return the page format key for the given size id */

QString pageFormatKey(QPageSize::PageSizeId pageSizeId);

KREPORT_EXPORT QPageSize::PageSizeId pageFormatSize(const QString& key);

I propose to change both methods to more object-oriented and very simple:

QSizeF KReportPageOptions::pixelSize() const

new line please

Really done?

Not done...

size -> key

QPageSize::PageSizeId -> QPageSize::PageSizeId id

let's removed unused

let's removed unused

still needed line?

let's removed unused

let's removed unused

Wouldn't more ideal to use scaleX, scaleY and use them respectively below?

I mean here, etc.

let's remove unused

let's remove unused

let's remove unused

let's remove unused

It simplifies but also a bit surprised because e.g API close to that, QPaintDevice::logicalDpi*() has both X and Y. I propose to have X and Y then...

Is there particular difficulty?

Existence of setDpi() suggests dpiY() is independent.

PS: when you change please also remove the comment in line 72