Show the actions in the apps and kontact plugins
ClosedPublic
Actions

Authored by ervin on Nov 12 2015, 9:56 PM.

Details

Reviewers

Commits

Repository

R4 Zanshin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ervin retitled this revision from to Show the actions in the apps and kontact plugins.

ervin updated this object.

ervin edited the test plan for this revision. (Show Details)

src/renku/app/main.cpp
78	That's a weird way of writing QHash<QString, QAction*> actions; Are you paid by the number of "auto" keywords you use? :-)
84	Red alert! foreach+keys()! Use a QHash iterator.

src/renku/app/main.cpp
78	Hehe, nope... but that's my line of experiments at the moment. After trying to push mock overboard and see where that hurts, I'm trying to push auto overboard. Interestingly so far I didn't find much pain I would even say "on the contrary" it reminds me of ML or Scala code to some extend. This experiment was prompted by: http://herbsutter.com/2013/08/12/gotw-94-solution-aaa-style-almost-always-auto/ (4.b and 5 mainly)

Address dfaure's comments

dfaure edited edge metadata.

This revision is now accepted and ready to land.Nov 15 2015, 10:41 PM

This revision was automatically updated to reflect the committed changes.

		Path
M		src/renku/app/CMakeLists.txt (1 line)
M		src/renku/app/main.cpp (11 lines)
A	M	src/renku/app/renkuui.rc (29 lines)
M		src/renku/kontact/part.cpp (9 lines)
M		src/renku/kontact/renku_part.rc (26 lines)
M		src/zanshin/app/CMakeLists.txt (1 line)
M		src/zanshin/app/main.cpp (11 lines)
A	M	src/zanshin/app/zanshin-nextui.rc (29 lines)
M		src/zanshin/kontact/part.cpp (9 lines)
M		src/zanshin/kontact/zanshin-next_part.rc (26 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	1274	367680a		Nov 12 2015, 9:56 PM	★	★
Diff 2	1295	e8c8eee	Address dfaure's comments	Nov 15 2015, 9:05 PM	★	★
Diff 3	1303	5d590d3	Commit rZANSHINb79032459133210f2e3db14d95eac4ce7ad33e3c	Nov 16 2015, 7:53 AM	★	★