Editor is now showing recurrence to the user
AbandonedPublic

Authored by ervin on Apr 9 2017, 3:19 PM.

Details

Summary

Recurrence is selectable only when the start date is valid

Test Plan

unit test

Diff Detail

Repository
R4 Zanshin
Lint
Lint Skipped
Unit
Unit Tests Skipped
franckarrecot created this revision.Apr 9 2017, 3:19 PM
ervin requested changes to this revision.May 16 2017, 3:30 PM
ervin added inline comments.
src/widgets/editorview.cpp
208

Better done in onStartDateChanged

259

This kind of C cast should be avoided I think. You should have a way to get to actual data from that index. Would be safer.

src/widgets/editorview.h
67

Drop the const since it's an enum for now. Or switch to const-ref if you expect that enum to grow into an object later on.

src/widgets/editorview.ui
33–44

Double margins got introduced I guess.

78–103

I generally prefer to do that from C++, so that you can map the strings to the enum values directly. More type safety that way by avoiding the horrible C cast above.

This revision now requires changes to proceed.May 16 2017, 3:30 PM
ervin commandeered this revision.Aug 13 2017, 11:09 PM
ervin abandoned this revision.
ervin edited reviewers, added: franckarrecot; removed: ervin.

Replaced by D7300.