Recurrence is selectable only when the start date is valid
Details
Details
Diff Detail
Diff Detail
- Repository
- R4 Zanshin
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/widgets/editorview.cpp | ||
---|---|---|
208 | Better done in onStartDateChanged | |
259 | This kind of C cast should be avoided I think. You should have a way to get to actual data from that index. Would be safer. | |
src/widgets/editorview.h | ||
67 | Drop the const since it's an enum for now. Or switch to const-ref if you expect that enum to grow into an object later on. | |
src/widgets/editorview.ui | ||
33–44 | Double margins got introduced I guess. | |
78–103 | I generally prefer to do that from C++, so that you can map the strings to the enum values directly. More type safety that way by avoiding the horrible C cast above. |