Differential D5359

cliunarchiver: Emit encryption method
ClosedPublic
Actions

Authored by rthomsen on Apr 9 2017, 10:07 AM.

Details

Reviewers
elvisangelaccio
Commits
R36:4834d58075cf: cliunarchiver: Emit encryption method
Summary

Emit AES192 for RAR4 archives and AES256 for RAR5 archives. This fixes the empty parenthesis in the properties dialog.

Test Plan

Open encrypted RAR4 and RAR5 archives and check that the correct encryption method is given in the properties dialog.

Diff Detail

Repository
R36 Ark
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rthomsen created this revision.Apr 9 2017, 10:07 AM
Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald TranscriptApr 9 2017, 10:07 AM
elvisangelaccio accepted this revision.Apr 9 2017, 3:40 PM
elvisangelaccio added inline comments.
plugins/cliunarchiverplugin/cliplugin.cpp
264

const bool, and remove the m_ prefix (not a class member variable).

This revision is now accepted and ready to land.Apr 9 2017, 3:40 PM
elvisangelaccio added inline comments.Apr 9 2017, 3:43 PM
plugins/cliunarchiverplugin/cliplugin.cpp
267

QLatin1String for the comparison.

Closed by commit R36:4834d58075cf: cliunarchiver: Emit encryption method (authored by rthomsen). · Explain WhyApr 13 2017, 7:58 AM
This revision was automatically updated to reflect the committed changes.
rthomsen mentioned this in R36:4834d58075cf: cliunarchiver: Emit encryption method.

Revision Contents
Changeset List

Diff 13373

View Options

plugins/cliunarchiverplugin/cliplugin.cpp

Loading...