Adapt akonadi serializer to support recurrence
AbandonedPublic
Actions

Authored by ervin on Apr 8 2017, 4:06 PM.

Details

Reviewers

Test Plan

unit tests

Repository

R4 Zanshin

Lint

Lint Skipped

Unit

Unit Tests Skipped

I'm digging the way to do the postpone to the next recurrence logic, I'll see if I add it in this commit or in an other one, most probably this one.

And the support for monthlyPosition will come later I think (impact quite a lot the soon to come gui patch).

ervin requested changes to this revision.May 16 2017, 3:22 PM

ervin added inline comments.

src/akonadi/akonadiserializer.cpp
218	taskRecurrenceFromTodo, it's not taking an Item as parameter.
266	Should be renamed I think it's not really a setter. Maybe don't even need to be put in a separate function in fact.
tests/units/akonadi/akonadiserializertest.cpp
573	Probably needs new cases with an actual recurrence.
609–610	It's wrong to use the serializer from the GIVEN like that. Could easily mask issues or wrong implementations.
735	Same as above.
788	ditto
2505–2560	I think the methods under test here shouldn't be public. So probably those tests would disappear, it's better to complete the data sets for the conversion methods IMO.