Member variable in task name m_recurrence is now tracking
the recurrence state. The domain is also enforcing the start date to be
given if you want the recurrence to exist. We'll enforce that in the view
as well.
Details
Details
- Reviewers
bensi dfaure franckarrecot
Unit tests
Diff Detail
Diff Detail
- Repository
- R4 Zanshin
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
A couple of issues and some questions.
| src/domain/task.cpp | ||
|---|---|---|
| 64 | What is it for? | |
| 84 | I don't see the point of that change in API since it still allows to set the recurrence independently without a start date. Also we could have a recurrence with only a due date I guess. I think we discussed that but I don't remember the specifics. | |
| tests/units/domain/tasktest.cpp | ||
| 236 | probably needs a else to check it's 0 otherwise | |
| 238 | ditto | |