Fix extraction of encrypted entries with the unar plugin
ClosedPublic
Actions

Authored by elvisangelaccio on Apr 7 2017, 4:34 PM.

Details

Reviewers

Commits

R36:b80d2e5cd2d0: Fix extraction of encrypted entries with the unar plugin

Summary

The passwordSwitch property is a QStringList and not a QString.
Thus converting from QVariant to QString breaks as soon as the list
contains more than one string, which is the case with the unar plugin.

BUG: 378507
FIXED-IN: 17.04.0

Test Plan

I can now open encrypted entries with the unar plugin. Other cli plugins still work.

Diff Detail

Repository

R36 Ark

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio created this revision.Apr 7 2017, 4:34 PM

Restricted Application added a project: Ark. · View Herald TranscriptApr 7 2017, 4:34 PM

Restricted Application added subscribers: Ark, kde-utils-devel. · View Herald Transcript

rthomsen accepted this revision.Apr 9 2017, 9:48 AM

This revision is now accepted and ready to land.Apr 9 2017, 9:48 AM

Closed by commit R36:b80d2e5cd2d0: Fix extraction of encrypted entries with the unar plugin (authored by elvisangelaccio). · Explain WhyApr 9 2017, 3:36 PM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in R36:b80d2e5cd2d0: Fix extraction of encrypted entries with the unar plugin.

Revision Contents
Changeset List

			Path	Packages
M			kerfuffle/cliinterface.cpp (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	13203	b61dfcb		Apr 7 2017, 4:34 PM	★	★
Diff 2	13261	2b771e9	R36:b80d2e5cd2d0c12a922172083410e8b4bcd6130a	Apr 9 2017, 3:37 PM	★	★

Diff 13261

View Options

kerfuffle/cliinterface.cpp