Old version ignores InsertionPolicy::AtBottom enum value and produce behavior same as for InsertionPolicy::AtTop.
Details
Details
- Reviewers
aacid - Group Reviewers
Frameworks - Commits
- R236:d47b970e9802: Fix KActionSelectorPrivate::insertionIndex()
Diff Detail
Diff Detail
- Repository
- R236 KWidgetsAddons
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Is this really needed?
Without your code it defaults to
index = -1;
what is the same as appending that is the same as atBottom, no?
Comment Actions
Is this really needed?
Without your code it defaults to
index = -1;
what is the same as appending that is the same as atBottom, no?
Yes, it needed - see here about negative index http://code.qt.io/cgit/qt/qtbase.git/tree/src/widgets/itemviews/qlistwidget.cpp#n108
Comment Actions
Right.
Would be nice to have an autotest for this but since there's no autotest for KActionSelector at all that i can see i'm not going to block you on that :)