Improve WHERE conditions handling in query and report designers

Authored by staniek on Apr 3 2017, 11:44 PM.



Fix building WHERE conditions in query designers

  • fixed typo while porting to Kexi 3
  • check for null WHERE expression instead of valid expression because validity can't be computed so early

Fix updating SQL statement in SQL designer after switching from other views and property revert to previous SQL

When clearing data cursor while resetting query data view also clear cached data

+ add more checks for existence of data because now it's possible that data is missing


Test Plan

Run query designer, set one WHERE condition, switch to data and SQL view, change the condition in the SQL view.
Repeat for 2 or more conditions. Use relations such as = < <= > >= and without relation (defaults to =).

Needed KDb patches: D5294

Note: for 3.0 branches! Will be merged to master when accepted.

Diff Detail

R71 Kexi
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
staniek created this revision.Apr 3 2017, 11:44 PM
Restricted Application added a project: Kexi. · View Herald TranscriptApr 3 2017, 11:44 PM
staniek edited the test plan for this revision. (Show Details)Apr 3 2017, 11:46 PM
staniek added a reviewer: piggz.
staniek added a subscriber: piggz.
staniek edited the summary of this revision. (Show Details)Apr 3 2017, 11:49 PM

@piggz Committed but I'd like to ask for auditing this

This revision was automatically updated to reflect the committed changes.