Differential D5147

Mark "all categories missing" kns sources as invalid
ClosedPublic
Actions

Authored by leinir on Mar 23 2017, 10:35 AM.

Details

Reviewers
apol
Summary

KNS being, at times, a little twitchy means that we have to handle such things a bit more gracefully. As such, without this code, the KNS backend would remain in a perpetial search state after startup, which would result in inconsistencies.

Diff Detail

Repository
R134 Discover Software Store
Lint
Lint Skipped
Unit
Unit Tests Skipped
leinir created this revision.Mar 23 2017, 10:35 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMar 23 2017, 10:35 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
apol added inline comments.Mar 23 2017, 12:32 PM
libdiscover/backends/KNSBackend/KNSBackend.cpp
111

Could be moved into a proper slot?

200

Unrelated change

apol accepted this revision.Mar 23 2017, 12:32 PM
This revision is now accepted and ready to land.Mar 23 2017, 12:32 PM
leinir closed this revision.Mar 23 2017, 12:38 PM

Closed by commit 1db3b40cc4f979cc8c50dcfc1a41cddcce973ae7

libdiscover/backends/KNSBackend/KNSBackend.cpp
111

It /is/ starting to be more than trivial code in there, that'd make sense, yeah. i'm sure this won't be the last time changes happen to the kns error handling code, i'll move it into a proper slot next time 'round :)

200

Ah, yes, so it is! Was tracking where things were breaking and whatnot, and thought it'd probably be useful to keep that modification for future similar tracking of things :)

Revision Contents
Changeset List

Diff 12719

View Options

libdiscover/backends/KNSBackend/KNSBackend.cpp

Loading...