Differential D5107

ITIPHandler: emit correct signal in case of an error loading the calendar.
ClosedPublic
Actions

Authored by dfaure on Mar 19 2017, 6:13 PM.

Details

Reviewers
mlaurent
smartins
Commits
R170:12711617070b: ITIPHandler: emit correct signal in case of an error loading the calendar.
Summary

This block is inside if (m_currentOperation == OperationProcessiTIPMessage)
so this is the signal that the caller (SyncItipHandler in kdepim-addons) expects.

Whether one faulty calendar item should lead to a complete calendar loading
failure, a messagebox when accepting an invitation, and a failure to insert
the invitation into the calendar, is another debate (and another fix surely),
but at least the event loop in SyncItipHandler finishes on error too.

Test Plan

Clicking on an acceptation in kmail, with (apparently) invalid
kolab calendar items in shared folders.

Diff Detail

Repository
R170 Akonadi Calendar
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dfaure created this revision.Mar 19 2017, 6:13 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 19 2017, 6:13 PM
mlaurent added a subscriber: mlaurent.Mar 20 2017, 6:17 AM

Hi,
Indeed I can't find where iTipMessageSent is used. So your fix allows to fix finish action.

now we have 17.04 branch :) You can switch to 17.04 :)

Thanks
Regards

mlaurent accepted this revision.Mar 20 2017, 6:17 AM
This revision is now accepted and ready to land.Mar 20 2017, 6:17 AM
smartins edited edge metadata.Mar 20 2017, 6:12 PM

looks correct

Closed by commit R170:12711617070b: ITIPHandler: emit correct signal in case of an error loading the calendar. (authored by dfaure). · Explain WhyMar 21 2017, 7:28 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/itiphandler_p.cpp (4 lines)

Diff 12664

View Options

src/itiphandler_p.cpp

Loading...