I want to rename clips more easily. Recently I have filed a feature request: https://bugs.kde.org/show_bug.cgi?id=377585
Here is my preliminary patch, which implements right mouse button menu for renaming clip in project bin.
However, I did not understand what is the differences between ProjectClip and ProjectSubClip classed. They both are described as "Represents a clip in the project (not timeline)" in header files.
Please, let me know if all is done correctly.
Details
Details
- Reviewers
vpinon mardelle massimostella frdbr
Diff Detail
Diff Detail
- Repository
- R158 Kdenlive
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Comment Actions
Thanks for the patch. In fact, we could simply make the slotRenameFolder() method more generic, with an action simply called "Rename" that would rename the currently selected item (Folder, Clip or SubClip).
A SubClip is a clip zone, that can be created by dragging a monitor zone into the bin. It's a way to keep parts of a clip easily accessible, and then appears as a child of a clip.
However there is currently a problem with the rename method (unrelated to your patch) that discards the rename action when triggered from the context menu. I am investigating and will come back to you soon.
Comment Actions
So I did commit something very similar to your patch in git master, and the standard shortcut now works. I forgot to mention you in the commit log, sorry. Anyways a big thank you for raising the issue and providing a patch that helped implementing the feature. A small issue remains when trying to rename through the context menu, because sometimes the editor closes immediatly because of a focus event that I could not debug. Shortcut seems to work flawlessly thought.