Differential D505

Do not use visual category from ways if ways have different visual categories.
ClosedPublic
Actions

Authored by ematirov on Nov 5 2015, 6:29 PM.

Details

Reviewers
nienhueser
Group Reviewers
Marble
Commits
R34:0ecfd8df9703: Do not use visual category from ways if ways have different visual categories.
Summary

Do not use visual category from ways if ways have different visual categories because sometimes it leads to incorrect result.

Before:

After:

Place is 12° 29' 21.8"E, 41° 53' 21.0"N

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
ematirov updated this revision to Diff 1181.Nov 5 2015, 6:29 PM
ematirov retitled this revision from to Do not use visual category from ways if ways have different visual categories..
ematirov updated this object.
ematirov edited the test plan for this revision. (Show Details)
ematirov added a reviewer: Marble.
ematirov set the repository for this revision to R34 Marble.
ematirov added a project: Marble.
nienhueser added a subscriber: nienhueser.Nov 5 2015, 6:43 PM
nienhueser added inline comments.
src/plugins/runner/osm/OsmRelation.cpp
70

Shouldn't this one still check whether category != GeoDataFeature::None?

ematirov updated this revision to Diff 1182.Nov 5 2015, 7:27 PM
nienhueser added inline comments.Nov 10 2015, 8:35 PM
src/plugins/runner/osm/OsmRelation.cpp
73 ↗(On Diff #1182)

shouldn't this be in the scope above where outerCategory is actually being changed?

ematirov updated this revision to Diff 1290.Nov 15 2015, 10:04 AM
ematirov removed R34 Marble as the repository for this revision.
ematirov marked an inline comment as done.
ematirov set the repository for this revision to R34 Marble.
nienhueser accepted this revision.Nov 22 2015, 1:49 PM
nienhueser added a reviewer: nienhueser.

Looks good.

This revision is now accepted and ready to land.Nov 22 2015, 1:49 PM
Closed by commit R34:0ecfd8df9703: Do not use visual category from ways if ways have different visual categories. (authored by ematirov). · Explain WhyNov 24 2015, 5:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 1290

View Options

src/plugins/runner/osm/OsmRelation.cpp

Loading...