Differential D5055

Fix installation of icons
ClosedPublic
Actions

Authored by fvogt on Mar 15 2017, 8:07 AM.

Details

Reviewers
mlaurent
dvratil
Commits
R206:fcb5e0967bf7: Fix installation of icons
Summary

Without this patch, only svg icons would end up being installed as
the file(GLOB ...) line overwrote the previous content of ${icons}.

Test Plan

Some debug output with message(), did not do a full build.

Diff Detail

Repository
R206 KMail
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
fvogt created this revision.Mar 15 2017, 8:07 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptMar 15 2017, 8:07 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
dvratil accepted this revision.Mar 15 2017, 9:38 AM

Thanks! I haven't realized file() won't append to the list.

This revision is now accepted and ready to land.Mar 15 2017, 9:38 AM
Closed by commit R206:fcb5e0967bf7: Fix installation of icons (authored by fvogt). · Explain WhyMar 15 2017, 9:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/icons/CMakeLists.txt (5 lines)

Diff 12484

View Options

src/icons/CMakeLists.txt

Loading...