The plugin is set as optional but with highest priority for zip archives.
Details
Diff Detail
- Repository
- R36 Ark
- Lint
Lint Skipped - Unit
Unit Tests Skipped
plugins/CMakeLists.txt | ||
---|---|---|
14 ↗ | (On Diff #12444) | Shouldn't we add the plugin only if libzip >= 1.2 has been found? |
plugins/libzipplugin/libzipplugin.cpp | ||
---|---|---|
2 ↗ | (On Diff #12444) | 2017 |
72 ↗ | (On Diff #12444) | Declare variable as close as possible to where they are needed. In this case this could just be: zip_t *archive = zip_open(...); |
118 ↗ | (On Diff #12444) | same here. |
175 ↗ | (On Diff #12444) | We are not using the return value of std::bind(), are we? Is there a reason why we need the ugly Callback<void(double)>::func here? |
255 ↗ | (On Diff #12444) | The Entry objects need to be deleted. I think here we should do what libarchive does, i.e. delete them (later) in the destructor. |
432 ↗ | (On Diff #12444) | Remove m_abortOperation. The libzip plugin will run in another thread, we need to use QThread::currentThread()->isInterruptionRequested() instead of this boolean flag. Have a look at the libarchive plugin. |
581 ↗ | (On Diff #12444) | nullptr? |
plugins/libzipplugin/libzipplugin.h | ||
2 ↗ | (On Diff #12444) | 2017 :p |
60–63 ↗ | (On Diff #12444) | Either initialize all the member variables here on in the constructor initializer list. |
Actually only one failure in adddialogtest:
FAIL! : AddDialogTest::testBasicWidgets(zip) 'collapsibleCompression->isEnabled()' returned FALSE. () Loc: [/home/elvis/dev/kde/src/ark/autotests/kerfuffle/adddialogtest.cpp(124)]